git: correctly extract tag name when commit has multiple decorations#1188
Merged
Conversation
Signed-off-by: Luca Comellini <luca.com@gmail.com>
lucacome
force-pushed
the
fix/git-context
branch
from
June 19, 2026 01:16
9779743 to
91d6d42
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
|
Thanks! I added a follow-up commit that keeps your fix for commits with multiple decorations, but avoids parsing the tag name by splitting the Git allows commas in tag names, so a decoration like I also added a regression test for a comma-containing tag name and updated the detached-tag tests for the extra Git query. |
Contributor
Author
|
Cool, sounds good to me! 🙂 |
crazy-max
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the tag reference parsing in
Git.ref()to ensure the method always returns the correct tag ref even if other decorations are present.